I uploaded a new patch set that addresses the comments and fixes a representation bug.
http://codereview.chromium.org/11033005/diff/2001/src/arm/simulator-arm.cc File src/arm/simulator-arm.cc (right): http://codereview.chromium.org/11033005/diff/2001/src/arm/simulator-arm.cc#newcode1503 src/arm/simulator-arm.cc:1503: } else { On 2012/10/01 19:41:17, Jay Conrod wrote:
Erik Corry expressed some suspicion in my first rev about the shifts,
and I
agree. "result" is signed (int32_t), so >> will sign extend. Also
*carry_out
should contain the last bit that was shifted, so it can be (static_cast<uint32_t>(result) >> 31) != 0, right?
Yes, you're right. I am taking the updated implementation that you uploaded in the other CL. http://codereview.chromium.org/11033005/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
