LGTM (with comments).
https://codereview.chromium.org/11035054/diff/1/src/parser.cc File src/parser.cc (right): https://codereview.chromium.org/11035054/diff/1/src/parser.cc#newcode2847 src/parser.cc:2847: heap_factory->NewStringFromAscii(CStrVector(".for.")); You could move this symbol into the root-set by adding it to SYMBOL_LIST, call it e.g. dot_for_symbol and then access it through factory->dot_for_symbol(). Also does the name really need to be different for every temporary, or could we use the one symbol for all temporaries? https://codereview.chromium.org/11035054/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
