Uploaded new patch set.
https://chromiumcodereview.appspot.com/11087047/diff/4001/src/arm/assembler-arm.cc
File src/arm/assembler-arm.cc (right):
https://chromiumcodereview.appspot.com/11087047/diff/4001/src/arm/assembler-arm.cc#newcode81
src/arm/assembler-arm.cc:81: answer |= 1u << UNALIGNED_ACCESSES;
On 2012/10/10 11:11:19, Michael Starzinger wrote:
It seems the UNALIGNED_ACCESSES capability solely depends on the ARMv7
capability. Couldn't we just reuse the ARMv7 capability instead?
There could be non-ARMv7 processors that support this capability, but it
is difficult detect. For now, we just allow unaligned accesses for
ARMv7.
We could alias UNALIGNED_ACCESSES to ARMv7, but IMO we should keep
separate names for capabilities.
https://chromiumcodereview.appspot.com/11087047/diff/4001/src/arm/simulator-arm.cc
File src/arm/simulator-arm.cc (right):
https://chromiumcodereview.appspot.com/11087047/diff/4001/src/arm/simulator-arm.cc#newcode1072
src/arm/simulator-arm.cc:1072: } else if ((addr & 3) == 0) {
On 2012/10/10 10:35:08, JF wrote:
Why not fold this into the previous block?
if (FLAG_... || ((addr & 3) == 0)) {
} else {
// UNIMPLEMENTED();
}
Same for the other functions below.
Done, thanks.
https://chromiumcodereview.appspot.com/11087047/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
