Reviewers: Jakob,
Message:
PTAL.
Description:
Make EnumCacheBridge immutable.
Please review this at https://chromiumcodereview.appspot.com/11048051/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/objects.cc
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index
aa59047927fa2ec6e8ef15694acfb5425d068086..42152d5d89da1c5e36148526c7893a5ac725a9f2
100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -6098,20 +6098,13 @@ void DescriptorArray::SetEnumCache(FixedArray*
bridge_storage,
Object* new_index_cache) {
ASSERT(bridge_storage->length() >= kEnumCacheBridgeLength);
ASSERT(new_index_cache->IsSmi() || new_index_cache->IsFixedArray());
- if (HasEnumCache()) {
- ASSERT(new_cache->length() > GetEnumCache()->length());
- FixedArray::cast(get(kEnumCacheIndex))->
- set(kEnumCacheBridgeCacheIndex, new_cache);
- FixedArray::cast(get(kEnumCacheIndex))->
- set(kEnumCacheBridgeIndicesCacheIndex, new_index_cache);
- } else {
- ASSERT(!IsEmpty());
- FixedArray::cast(bridge_storage)->
- set(kEnumCacheBridgeCacheIndex, new_cache);
- FixedArray::cast(bridge_storage)->
- set(kEnumCacheBridgeIndicesCacheIndex, new_index_cache);
- set(kEnumCacheIndex, bridge_storage);
- }
+ ASSERT(!IsEmpty());
+ ASSERT(!HasEnumCache() || new_cache->length() >
GetEnumCache()->length());
+ FixedArray::cast(bridge_storage)->
+ set(kEnumCacheBridgeCacheIndex, new_cache);
+ FixedArray::cast(bridge_storage)->
+ set(kEnumCacheBridgeIndicesCacheIndex, new_index_cache);
+ set(kEnumCacheIndex, bridge_storage);
}
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
