Addressed comments, landing.
https://codereview.chromium.org/11092081/diff/1/test/cctest/test-api.cc File test/cctest/test-api.cc (right): https://codereview.chromium.org/11092081/diff/1/test/cctest/test-api.cc#newcode2 test/cctest/test-api.cc:2: On 2012/10/12 11:08:07, Michael Starzinger wrote:
That looks like a typo?
Done. https://codereview.chromium.org/11092081/diff/1/test/cctest/test-api.cc#newcode10844 test/cctest/test-api.cc:10844: // Fire context disposed notification to force clearing monomorphic ICs. On 2012/10/12 11:08:07, Michael Starzinger wrote:
I think we can drop the comment, the method call itself should be self-explanatory. Same for the rest of the function.
Done. https://codereview.chromium.org/11092081/diff/1/test/mjsunit/debug-script.js File test/mjsunit/debug-script.js (right): https://codereview.chromium.org/11092081/diff/1/test/mjsunit/debug-script.js#newcode29 test/mjsunit/debug-script.js:29: // Flags: --send-idle-notification On 2012/10/12 11:08:07, Michael Starzinger wrote:
Add empty newline after the second "// Flags" comment.
Done. https://codereview.chromium.org/11092081/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
