LGTM (with nits).
https://codereview.chromium.org/11111015/diff/1/src/runtime.cc File src/runtime.cc (right): https://codereview.chromium.org/11111015/diff/1/src/runtime.cc#newcode11796 src/runtime.cc:11796: Remove second empty newline for readability. https://codereview.chromium.org/11111015/diff/1/test/cctest/test-debug.cc File test/cctest/test-debug.cc (right): https://codereview.chromium.org/11111015/diff/1/test/cctest/test-debug.cc#newcode2503 test/cctest/test-debug.cc:2503: if (eventDetails.GetEvent() == v8::Break) Either on one line or add curly brackets. https://codereview.chromium.org/11111015/diff/1/test/cctest/test-debug.cc#newcode2534 test/cctest/test-debug.cc:2534: Add second empty newline for readability. https://codereview.chromium.org/11111015/diff/1/test/cctest/test-debug.cc#newcode2590 test/cctest/test-debug.cc:2590: Add second empty newline for readability. https://codereview.chromium.org/11111015/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
