LGTM with comments.

https://codereview.chromium.org/11137016/diff/1/ChangeLog
File ChangeLog (right):

https://codereview.chromium.org/11137016/diff/1/ChangeLog#newcode6
ChangeLog:6: Ensure code flushing is disabled in incremental marking.
(issue 1609)
nit: past tense please.

On a higher level, I don't think this entry is interesting. Let's just
drop it.

https://codereview.chromium.org/11137016/diff/1/ChangeLog#newcode8
ChangeLog:8: Move code flushing support into shared visitor. (issue
1609)
Same here. Past tense if you insist on keeping it, but internal
refactorings/cleanup don't really deserve a ChangeLog entry.

https://codereview.chromium.org/11137016/diff/1/ChangeLog#newcode10
ChangeLog:10: Enable --verify-heap in release mode (issue 2120)
nit: past tense please

https://codereview.chromium.org/11137016/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to