https://codereview.chromium.org/11093046/diff/1/build/common.gypi File build/common.gypi (right):
https://codereview.chromium.org/11093046/diff/1/build/common.gypi#newcode354 build/common.gypi:354: 'defines': ['ENABLE_GDB_JIT_INTERFACE',], This broke debugging of chrome, at least with gdb v7.5 -- gdb fails with "Unable to read JIT descriptor from remote memory!" followed by "Error accessing memory address 0xXXXXXXXXX: Input/output error". Is there a reason that v8_enable_gdbjit variable is not used here? What I would do instead of unconditionally adding the DEFINE, set the default value of v8_enable_gdbjit to 1: 'variables': { 'v8_enable_gdbjit%': 1 } so that those for whom gdbjit still does not work at least have a way to turn it off in their include.gypi. https://codereview.chromium.org/11093046/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
