This is looking good. Just some minor nits. Unfortunately I will be OOO
until
next week. I'll give this to Sven so he can land it for you.
https://codereview.chromium.org/11190011/diff/12001/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/11190011/diff/12001/include/v8.h#newcode405
include/v8.h:405: inline bool IsIndependent() const;
Add short one-liner comment about this function.
https://codereview.chromium.org/11190011/diff/12001/include/v8.h#newcode422
include/v8.h:422: inline uint16_t WrapperClassId() const;
Either adapt the above comment to cover both functions or add separate
comment for the getter.
https://codereview.chromium.org/11190011/diff/12001/include/v8.h#newcode3017
include/v8.h:3017: * Interface for iterating though all external
resources in the heap.
s/though/through/
https://codereview.chromium.org/11190011/diff/12001/include/v8.h#newcode3027
include/v8.h:3027: * Interface for iterating though the persistent
handles in the heap.
s/though the/through all/
https://codereview.chromium.org/11190011/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
