https://chromiumcodereview.appspot.com/11184006/diff/2003/src/objects-inl.h
File src/objects-inl.h (right):

https://chromiumcodereview.appspot.com/11184006/diff/2003/src/objects-inl.h#newcode1418
src/objects-inl.h:1418: int size =
As discussed, please convert this into something a little more readable.

https://chromiumcodereview.appspot.com/11184006/diff/2003/src/objects-inl.h#newcode1435
src/objects-inl.h:1435: bool JSObject::TryTransitionToField(String* key)
{
This should only be called by handlified code, it should be clear from
API.

https://chromiumcodereview.appspot.com/11184006/diff/2003/src/objects.h
File src/objects.h (right):

https://chromiumcodereview.appspot.com/11184006/diff/2003/src/objects.h#newcode1626
src/objects.h:1626: inline bool TryTransitionToField(String* key);
must be static and use Handle<> just like other Handle APIs

https://chromiumcodereview.appspot.com/11184006/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to