Status: New
Owner: ----

New issue 2370 by [email protected]: dom-query.html spends ~10% of total time in OSAtomicAdd32Barrier on my Mac
http://code.google.com/p/v8/issues/detail?id=2370

dom-query.html spends ~10% of total time in OSAtomicAdd32Barrier on my Mac

That's a thread synchronization function, which is presumably part of the GetIsolate() call at the top of GetElementWithInterceptor (since my understanding is that you need to grab at per-thread storage to get the isolate)

MaybeObject* JSObject::GetElementWithInterceptor(Object* receiver,
                                                 uint32_t index) {
  Isolate* isolate = GetIsolate();

It looks like the caller KeyedLoadPropertyWithInterceptor already has an Isolate* at their call-site, they just need a way to pass it down into GetElementWithInterceptor.

Running Time    Self            Symbol Name
2798.0ms    9.1%        2798.0          OSAtomicAdd32Barrier$VARIANT$mp
1273.0ms 4.1% 0.0 v8::internal::JSObject::GetElementWithInterceptor(v8::internal::Object*, unsigned int) 1273.0ms 4.1% 0.0 v8::internal::KeyedLoadPropertyWithInterceptor(v8::internal::Arguments, v8::internal::Isolate*)

It's very possible I'm misunderstanding here. I don't have very good symbols in this build in order to identify which line number is hot.


--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to