Looks good; I have some minor comments.
https://codereview.chromium.org/11231002/diff/1/src/platform-cygwin.cc File src/platform-cygwin.cc (right): https://codereview.chromium.org/11231002/diff/1/src/platform-cygwin.cc#newcode789 src/platform-cygwin.cc:789: I think the implementation of StartSampling() and StopSampling() is missing here. https://codereview.chromium.org/11231002/diff/1/src/platform.h File src/platform.h (right): https://codereview.chromium.org/11231002/diff/1/src/platform.h#newcode763 src/platform.h:763: // Perform platform-specific initialization before DoSample() may be involed. typo: invoked https://codereview.chromium.org/11231002/diff/1/src/platform.h#newcode769 src/platform.h:769: StartSampling(); nit: {} please https://codereview.chromium.org/11231002/diff/1/src/platform.h#newcode773 src/platform.h:773: StopSampling(); nit: {} please https://codereview.chromium.org/11231002/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
