Reviewers: Sven Panne,
Description:
Fix ugly typo in GenerateNewNonStrictFast.
[email protected]
BUG=chromium:157520
TEST=mjsunit/regress/regress-crbug-157520
Please review this at https://codereview.chromium.org/11300008/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/ia32/code-stubs-ia32.cc
M src/x64/code-stubs-x64.cc
A + test/mjsunit/regress/regress-crbug-157520.js
Index: src/ia32/code-stubs-ia32.cc
diff --git a/src/ia32/code-stubs-ia32.cc b/src/ia32/code-stubs-ia32.cc
index
3b6987e6f4f0b195a44439e4a92c136e1ee49432..1d23c7e5d2fffecf54195359b600035e85fb3b48
100644
--- a/src/ia32/code-stubs-ia32.cc
+++ b/src/ia32/code-stubs-ia32.cc
@@ -3593,7 +3593,7 @@ void
ArgumentsAccessStub::GenerateNewNonStrictFast(MacroAssembler* masm) {
__ bind(&runtime);
__ pop(eax); // Remove saved parameter count.
__ mov(Operand(esp, 1 * kPointerSize), ecx); // Patch argument count.
- __ TailCallRuntime(Runtime::kNewStrictArgumentsFast, 3, 1);
+ __ TailCallRuntime(Runtime::kNewArgumentsFast, 3, 1);
}
Index: src/x64/code-stubs-x64.cc
diff --git a/src/x64/code-stubs-x64.cc b/src/x64/code-stubs-x64.cc
index
675d404b9d48000f3b1c3cbcd618ee56eaf7b4dc..f0f9c5d272ef926c58ac28e81d67ba6f00eeac66
100644
--- a/src/x64/code-stubs-x64.cc
+++ b/src/x64/code-stubs-x64.cc
@@ -2604,7 +2604,7 @@ void
ArgumentsAccessStub::GenerateNewNonStrictFast(MacroAssembler* masm) {
__ bind(&runtime);
__ Integer32ToSmi(rcx, rcx);
__ movq(Operand(rsp, 1 * kPointerSize), rcx); // Patch argument count.
- __ TailCallRuntime(Runtime::kNewStrictArgumentsFast, 3, 1);
+ __ TailCallRuntime(Runtime::kNewArgumentsFast, 3, 1);
}
Index: test/mjsunit/regress/regress-crbug-157520.js
diff --git a/test/mjsunit/regress/regress-148378.js
b/test/mjsunit/regress/regress-crbug-157520.js
similarity index 90%
copy from test/mjsunit/regress/regress-148378.js
copy to test/mjsunit/regress/regress-crbug-157520.js
index
d37cea1cf75b02888ec59231c65b5b6ac436d45c..ee81c444727dd8ec4e8fa65a5fd169d03fd7183f
100644
--- a/test/mjsunit/regress/regress-148378.js
+++ b/test/mjsunit/regress/regress-crbug-157520.js
@@ -25,14 +25,14 @@
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-"a".replace(/a/g, function() { return "c"; });
+// Flags: --nocrankshaft
-function test() {
- try {
- test();
- } catch(e) {
- "b".replace(/(b)/g, function() { return "c"; });
+(function(){
+ var f = function(arg) {
+ arg = 2;
+ return arguments[0];
+ };
+ for (var i = 0; i < 50000; i++) {
+ assertSame(2, f(1));
}
-}
-
-test();
+})();
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
