https://codereview.chromium.org/11271006/diff/2002/src/mark-compact.cc File src/mark-compact.cc (right):
https://codereview.chromium.org/11271006/diff/2002/src/mark-compact.cc#newcode964 src/mark-compact.cc:964: candidate = GetNextCandidate(*slot); On 2012/10/26 09:15:28, ulan1 wrote:
candidate = GetNextCandidate(candidate);
Would be more robust w.r.t. reordering of these two lines.
We cannot use the candidate variable here, because the visitor most probably updated the referenced stored at the slot. So we need to reload the reference and candidate should be considered a stale value at this point. https://codereview.chromium.org/11271006/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
