http://codereview.chromium.org/11307012/diff/1/src/arm/macro-assembler-arm.cc File src/arm/macro-assembler-arm.cc (right):
http://codereview.chromium.org/11307012/diff/1/src/arm/macro-assembler-arm.cc#newcode427 src/arm/macro-assembler-arm.cc:427: if (root->IsOddball() || root->IsMap() || Can you phrase this test as checking against a black-list rather than whitelist? i.e. only do the ldr on roots where this won't work, and everything else uses movw/movt? This will make sure that roots added in the future will also benefit without having to add them them to this whitelist. http://codereview.chromium.org/11307012/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
