LGTM if you beef up the tests as indicated

https://chromiumcodereview.appspot.com/11358011/diff/1/test/mjsunit/elements-length-no-holey.js
File test/mjsunit/elements-length-no-holey.js (right):

https://chromiumcodereview.appspot.com/11358011/diff/1/test/mjsunit/elements-length-no-holey.js#newcode32
test/mjsunit/elements-length-no-holey.js:32:
assertFalse(%HasFastHoleyElements(a));
assertTrue(%FastSmiElements(a));

https://chromiumcodereview.appspot.com/11358011/diff/1/test/mjsunit/regress/regress-delete-empty-double.js
File test/mjsunit/regress/regress-delete-empty-double.js (right):

https://chromiumcodereview.appspot.com/11358011/diff/1/test/mjsunit/regress/regress-delete-empty-double.js#newcode30
test/mjsunit/regress/regress-delete-empty-double.js:30: delete a[0];
 assertTrue(%HasFastDoubleElements(a));
 assertTrue(%HasFastHoleyElements(a));

https://chromiumcodereview.appspot.com/11358011/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to