LGTM
https://chromiumcodereview.appspot.com/11340010/diff/1/src/heap.cc File src/heap.cc (right): https://chromiumcodereview.appspot.com/11340010/diff/1/src/heap.cc#newcode1601 src/heap.cc:1601: } external_string_table_visitor(visitor); Please add a blank line here between the class definition and the invocation of Iterate, so it stands out more. Or you could move it down to the other invocation https://chromiumcodereview.appspot.com/11340010/diff/1/src/heap.cc#newcode1619 src/heap.cc:1619: } symbol_table_visitor(visitor); Blank line here please. https://chromiumcodereview.appspot.com/11340010/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
