Also, FYI.
It looks to me like setting elements in a loop is still being cached. The
following test fails with this patch applied to our branch, but passes if i
turn
off IC altogether:
// Observed not IC'd.
reset();
var obj = {};
Object.observe(obj, observer.callback);
for (var i = 0; i < 3; i++) {
obj[i] = i;
}
Object.deliverChangeRecords(observer.callback);
observer.assertCallbackRecords([
{ object: obj, name: "0", type: "new" },
{ object: obj, name: "1", type: "new" },
{ object: obj, name: "2", type: "new" },
]);
Note that if the assignment in the look is obj['foo' + i], then it passes --
thus my suspicion about elements being cached somehow through a different
path.
https://codereview.chromium.org/11347037/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
