Reviewers: ulan,
Description:
Support shared library build of Android for v8.
v8 depends on the system log library. If we built it as a separate so,
log needs to be included in the link step.
BUG=chromium:158821
Please review this at https://codereview.chromium.org/11369081/
SVN Base: http://git.chromium.org/external/v8.git@master
Affected files:
M tools/gyp/v8.gyp
Index: tools/gyp/v8.gyp
diff --git a/tools/gyp/v8.gyp b/tools/gyp/v8.gyp
index
c24314f9bf05edbe69708f7bbda31b9d9f85c2e2..aad07c70943bba0e3216b3a1f0fd71bc5b4d7ce4
100644
--- a/tools/gyp/v8.gyp
+++ b/tools/gyp/v8.gyp
@@ -69,6 +69,14 @@
],
},
'conditions': [
+ ['OS=="android"', {
+ 'libraries': [
+ '-llog',
+ ],
+ 'include_dirs': [
+ 'src/common/android/include',
+ ],
+ }],
['OS=="mac"', {
'xcode_settings': {
'OTHER_LDFLAGS': ['-dynamiclib', '-all_load']
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
