lgtm with comments
https://codereview.chromium.org/11362115/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/11362115/diff/1/src/objects.cc#newcode2971 src/objects.cc:2971: result = ConvertDescriptorToField(*name, *value, attributes); self-> https://codereview.chromium.org/11362115/diff/1/src/objects.cc#newcode2984 src/objects.cc:2984: result = ConvertTransitionToMapTransition( self-> https://codereview.chromium.org/11362115/diff/1/src/objects.cc#newcode3009 src/objects.cc:3009: self->EnqueueChangeRecord("updated", name, old_value); Wouldn't it be less error-prone to make EnqueueChangeRecord a static method that takes a handle in for the receiver? https://codereview.chromium.org/11362115/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
