Answer to comments. Updated patch will follow.
https://codereview.chromium.org/11275184/diff/1/SConstruct File SConstruct (right): https://codereview.chromium.org/11275184/diff/1/SConstruct#newcode183 SConstruct:183: 'arch:sh4': { OK. Im just wondering how to cross compile using GYP as the wiki only speaks about building v8 for ARM with the simulator on. Is there a document that explains it ? https://codereview.chromium.org/11275184/diff/1/src/full-codegen.h File src/full-codegen.h (right): https://codereview.chromium.org/11275184/diff/1/src/full-codegen.h#newcode131 src/full-codegen.h:131: // TODO(STM): what is this for ? Thanks for the exaplnation. For the moment cranckshaft is not available on sh4. https://codereview.chromium.org/11275184/diff/1/src/globals.h File src/globals.h (right): https://codereview.chromium.org/11275184/diff/1/src/globals.h#newcode133 src/globals.h:133: #error Target architecture sh4 is only supported on sh4 host
How about adding a simulator to allow development/testing on x86
hardware? :-) This is not planned as we use Qemu user mode along with a open source tool that we developed (www.proot.me) to run every validation and tests of v8 for sh4 on an x86 host. (I can show you the right command line if you are interested as it also work for ARM). https://codereview.chromium.org/11275184/diff/1/src/jsregexp.cc File src/jsregexp.cc (right): https://codereview.chromium.org/11275184/diff/1/src/jsregexp.cc#newcode6138 src/jsregexp.cc:6138: #elif V8_TARGET_ARCH_SH4
nit: let's keep the whitespace consistent
Typo. Fixed in the next version of the patch https://codereview.chromium.org/11275184/diff/1/src/platform-posix.cc File src/platform-posix.cc (right): https://codereview.chromium.org/11275184/diff/1/src/platform-posix.cc#newcode154 src/platform-posix.cc:154: // return a qNaN as exepcted by the v8 core. In sh4 tool chain, the NAN macro
nit: "Return", "expected"
Fixed. https://codereview.chromium.org/11275184/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
