LGTM with nits.
https://chromiumcodereview.appspot.com/11338048/diff/7001/src/accessors.cc File src/accessors.cc (right): https://chromiumcodereview.appspot.com/11338048/diff/7001/src/accessors.cc#newcode109 src/accessors.cc:109: while (end_index && end_index-- > new_length) { Can we make this a for loop? https://chromiumcodereview.appspot.com/11338048/diff/7001/src/accessors.cc#newcode121 src/accessors.cc:121: Nit: move the empty line down by 2. https://chromiumcodereview.appspot.com/11338048/diff/7001/test/mjsunit/harmony/object-observe.js File test/mjsunit/harmony/object-observe.js (right): https://chromiumcodereview.appspot.com/11338048/diff/7001/test/mjsunit/harmony/object-observe.js#newcode340 test/mjsunit/harmony/object-observe.js:340: Object.defineProperty(arr, '2', {get: function(){}}); Perhaps add the case of a non-configurable accessor. https://chromiumcodereview.appspot.com/11338048/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
