Looks good so far, but I think you need to look for other code paths that
might
set array elements, especially when doing it through Object.defineProperty.
https://chromiumcodereview.appspot.com/11369135/diff/1/src/objects.cc
File src/objects.cc (right):
https://chromiumcodereview.appspot.com/11369135/diff/1/src/objects.cc#newcode10322
src/objects.cc:10322: if (!preexists && self->IsJSArray())
Maybe make that an "else if (self->IsJSArray())"
https://chromiumcodereview.appspot.com/11369135/diff/1/src/objects.cc#newcode10349
src/objects.cc:10349: Handle<Object> newValue = Object::GetElement(self,
index);
Not your change, but while you're at it, can you also fix this
misspelling of 'newValue' I overlooked?
https://chromiumcodereview.appspot.com/11369135/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
