Revision: 12919
Author: [email protected]
Date: Fri Nov 9 05:04:51 2012
Log: Disable code aging due to bugs.
[email protected]
Review URL: https://codereview.chromium.org/11361182
http://code.google.com/p/v8/source/detail?r=12919
Modified:
/branches/bleeding_edge/src/flag-definitions.h
/branches/bleeding_edge/src/ia32/full-codegen-ia32.cc
/branches/bleeding_edge/src/ia32/lithium-codegen-ia32.cc
/branches/bleeding_edge/src/x64/full-codegen-x64.cc
/branches/bleeding_edge/src/x64/lithium-codegen-x64.cc
=======================================
--- /branches/bleeding_edge/src/flag-definitions.h Thu Nov 8 09:31:45 2012
+++ /branches/bleeding_edge/src/flag-definitions.h Fri Nov 9 05:04:51 2012
@@ -396,7 +396,7 @@
"flush code that we expect not to use again (during full gc)")
DEFINE_bool(flush_code_incrementally, false,
"flush code that we expect not to use again (incrementally)")
-DEFINE_bool(age_code, true,
+DEFINE_bool(age_code, false,
"track un-executed functions to age code and flush only "
"old code")
DEFINE_bool(incremental_marking, true, "use incremental marking")
=======================================
--- /branches/bleeding_edge/src/ia32/full-codegen-ia32.cc Thu Nov 8
04:18:11 2012
+++ /branches/bleeding_edge/src/ia32/full-codegen-ia32.cc Fri Nov 9
05:04:51 2012
@@ -151,7 +151,8 @@
__ mov(Operand(esp, receiver_offset),
Immediate(isolate()->factory()->undefined_value()));
__ bind(&ok);
- ASSERT_EQ(kSizeOfFullCodegenStrictModePrologue, ok.pos() -
start.pos());
+ ASSERT(!FLAG_age_code ||
+ (kSizeOfFullCodegenStrictModePrologue == ok.pos() -
start.pos()));
}
// Open a frame scope to indicate that there is a frame on the stack.
The
=======================================
--- /branches/bleeding_edge/src/ia32/lithium-codegen-ia32.cc Fri Nov 9
02:21:07 2012
+++ /branches/bleeding_edge/src/ia32/lithium-codegen-ia32.cc Fri Nov 9
05:04:51 2012
@@ -150,7 +150,8 @@
__ mov(Operand(esp, receiver_offset),
Immediate(isolate()->factory()->undefined_value()));
__ bind(&ok);
- ASSERT_EQ(kSizeOfOptimizedStrictModePrologue, ok.pos() - begin.pos());
+ ASSERT(!FLAG_age_code ||
+ (kSizeOfOptimizedStrictModePrologue == ok.pos() - begin.pos()));
}
@@ -179,8 +180,9 @@
__ j(not_zero, &align_loop, Label::kNear);
__ mov(Operand(ebx, 0), Immediate(kAlignmentZapValue));
__ bind(&do_not_pad);
- ASSERT_EQ(kSizeOfOptimizedAlignStackPrologue,
- do_not_pad.pos() - begin.pos());
+ ASSERT(!FLAG_age_code ||
+ (kSizeOfOptimizedAlignStackPrologue ==
+ do_not_pad.pos() - begin.pos()));
}
__ push(ebp); // Caller's frame pointer.
=======================================
--- /branches/bleeding_edge/src/x64/full-codegen-x64.cc Thu Nov 8 04:18:11
2012
+++ /branches/bleeding_edge/src/x64/full-codegen-x64.cc Fri Nov 9 05:04:51
2012
@@ -147,7 +147,8 @@
__ LoadRoot(kScratchRegister, Heap::kUndefinedValueRootIndex);
__ movq(Operand(rsp, receiver_offset), kScratchRegister);
__ bind(&ok);
- ASSERT_EQ(kSizeOfFullCodegenStrictModePrologue, ok.pos() -
begin.pos());
+ ASSERT(!FLAG_age_code ||
+ (kSizeOfFullCodegenStrictModePrologue == ok.pos() -
begin.pos()));
}
// Open a frame scope to indicate that there is a frame on the stack.
The
=======================================
--- /branches/bleeding_edge/src/x64/lithium-codegen-x64.cc Fri Nov 9
02:21:07 2012
+++ /branches/bleeding_edge/src/x64/lithium-codegen-x64.cc Fri Nov 9
05:04:51 2012
@@ -143,7 +143,8 @@
__ LoadRoot(kScratchRegister, Heap::kUndefinedValueRootIndex);
__ movq(Operand(rsp, receiver_offset), kScratchRegister);
__ bind(&ok);
- ASSERT_EQ(kSizeOfOptimizedStrictModePrologue, ok.pos() - begin.pos());
+ ASSERT(!FLAG_age_code ||
+ (kSizeOfOptimizedStrictModePrologue == ok.pos() - begin.pos()));
}
__ push(rbp); // Caller's frame pointer.
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
