Reviewers: danno,
Description:
Fixed Code::FindCodeAgeSequence logic, removing a dead method on the way.
Please review this at http://codereview.chromium.org/11364177/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/mips/assembler-mips.h
M src/objects.cc
Index: src/mips/assembler-mips.h
diff --git a/src/mips/assembler-mips.h b/src/mips/assembler-mips.h
index
22396b37d09e253b42550e9a2e76e39cf697b446..fd2ff0daa2804c3abd1d21caa84d15dd8070ccd6
100644
--- a/src/mips/assembler-mips.h
+++ b/src/mips/assembler-mips.h
@@ -525,9 +525,6 @@ class Assembler : public AssemblerBase {
Assembler(Isolate* isolate, void* buffer, int buffer_size);
~Assembler();
- // Dummy for cross platform compatibility.
- void set_predictable_code_size(bool value) { }
-
// GetCode emits any pending (non-emitted) code and fills the descriptor
// desc. GetCode() is idempotent; it returns the same result if no other
// Assembler functions are invoked in between GetCode() calls.
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index
7969e7d4c561c8726112f1aa6fa909238e74020e..bd290d9d3dc48c81e2aad66debba733cb729e3f6
100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -8834,13 +8834,13 @@ bool Code::IsOld() {
byte* Code::FindCodeAgeSequence() {
- if (kind() != FUNCTION && kind() != OPTIMIZED_FUNCTION) return NULL;
- if (strlen(FLAG_stop_at) == 0 &&
+ return FLAG_age_code &&
+ strlen(FLAG_stop_at) == 0 &&
!ProfileEntryHookStub::HasEntryHook() &&
- (kind() == FUNCTION && !has_debug_break_slots())) {
- return FindPlatformCodeAgeSequence();
- }
- return NULL;
+ (kind() == OPTIMIZED_FUNCTION ||
+ (kind() == FUNCTION && !has_debug_break_slots()))
+ ? FindPlatformCodeAgeSequence()
+ : NULL;
}
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
