Reviewers: danno, Toon Verwaest, Michael Starzinger,
Message:
Hi guys,
This code is not ready for prime time yet, I expect to make a few more
important
revisions Monday and Tuesday. But the functionality is there. The "meat" is
in
hydrogen.cc, where the list of DeferredTransitions are processed to find
Terminal Nodes (my term), to negotiate the unified and maximum ElementsKind
(to->from) span, to patch the graph appropriately.
The "chaining" of outputs through the transitions we discussed the other
day is
not in place, but adequate dependency management should allow me to save
that
for a follow-on checkin.
Something I need to think about over the weekend is that I try to select
HLoad/StoreKeyed nodes carefully for deferred initialization, but this
happens
far enough away from the place where I decide if an attempt at transition
deferment should be run that I have an error. These need to be tightly
coupled.
So not ready for review, but if you see anything really out there you could
let
me know, thx!
Description:
A change in the way we place TransitionElementKinds in the tree.
I attempt to place them as close to object definition as possible, in the
hopes of getting them out of loops.
There is currently a weakness that the deferment isn't strongly tied to the
creation of a DeferredTransition structure. There are currently some failing
tests because of this.
BUG=
Please review this at https://codereview.chromium.org/11365174/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/compiler.cc
M src/elements-kind.h
M src/elements-kind.cc
M src/flag-definitions.h
M src/hydrogen-instructions.h
M src/hydrogen.h
M src/hydrogen.cc
M src/objects.h
M src/objects.cc
M src/v8-counters.h
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev