Some comments.
https://codereview.chromium.org/11365202/diff/1/samples/shell.cc File samples/shell.cc (right): https://codereview.chromium.org/11365202/diff/1/samples/shell.cc#newcode253 samples/shell.cc:253: fprintf(stderr, "V8 version %s [sample shell]\n", v8::V8::GetVersion()); This is the prompt of the interactive shell and must not go to stderr. https://codereview.chromium.org/11365202/diff/1/samples/shell.cc#newcode260 samples/shell.cc:260: fprintf(stderr, "> "); Ditto. https://codereview.chromium.org/11365202/diff/1/samples/shell.cc#newcode266 samples/shell.cc:266: fprintf(stderr, "\n"); Ditto. https://codereview.chromium.org/11365202/diff/1/samples/shell.cc#newcode314 samples/shell.cc:314: fprintf(stderr, "%s\n", exception_string); This reports uncaught exceptions caused in javascript. I think the policy should be that error messages caused in this shell (like failed read of a file) should go to stderr and error messages of the javascript runtime should go to stdout. Same goes for all the output in this function. https://codereview.chromium.org/11365202/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
