lgtm with nit
https://codereview.chromium.org/11275283/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/11275283/diff/1/src/objects.cc#newcode10310 src/objects.cc:10310: return HasIndexedInterceptor() +1 On 2012/11/13 13:18:44, rafaelw wrote:
consider factoring out into inline static?
https://codereview.chromium.org/11275283/diff/1/src/objects.cc#newcode10344 src/objects.cc:10344: if (old_attributes == ABSENT) { On 2012/11/13 13:18:44, rafaelw wrote:
nit: return early here. e.g.
if (old_attributes != ABSENT) return *hresult;
EnqueueChangeRecord...
This doesn't seem possible, given that the value is possibly updated, or the property was reconfigured. https://codereview.chromium.org/11275283/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
