LGTM with nit
http://codereview.chromium.org/11359104/diff/6001/src/hydrogen.cc File src/hydrogen.cc (right): http://codereview.chromium.org/11359104/diff/6001/src/hydrogen.cc#newcode7515 src/hydrogen.cc:7515: // Checks if all maps in |types| are from the same family, ie, are elements nit: i.e. http://codereview.chromium.org/11359104/diff/6001/src/hydrogen.cc#newcode7519 src/hydrogen.cc:7519: static Map* CheckSameElementsFamily(SmallMapList* types) { Maybe this should be a static method on Map? I know that Michael might want to reuse some of this functionality? http://codereview.chromium.org/11359104/diff/6001/src/hydrogen.cc#newcode7607 src/hydrogen.cc:7607: if (!monomorphic) { since you handle both cases, why not make it "if (monomorphic)" with the positive case first? http://codereview.chromium.org/11359104/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
