LGTM with nits
http://codereview.chromium.org/11358214/diff/1/src/messages.js File src/messages.js (right): http://codereview.chromium.org/11358214/diff/1/src/messages.js#newcode258 src/messages.js:258: var e = new constructor(FormatMessage(type, args)); Just drop the "var e =", it's cleaner... ;-) http://codereview.chromium.org/11358214/diff/1/test/cctest/test-parsing.cc File test/cctest/test-parsing.cc (right): http://codereview.chromium.org/11358214/diff/1/test/cctest/test-parsing.cc#newcode1095 test/cctest/test-parsing.cc:1095: i::Handle<i::String> message_string; Remove this line, merging it with the initialization below. In general, we should avoid declaring any uninitialized variable. (Yes, I know, this one is initialized via it's default constructor, but in a way it is still uninitialized.) http://codereview.chromium.org/11358214/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
