LGTM with two comments.
https://codereview.chromium.org/11275229/diff/1/src/spaces-inl.h File src/spaces-inl.h (right): https://codereview.chromium.org/11275229/diff/1/src/spaces-inl.h#newcode167 src/spaces-inl.h:167: ASSERT(page->area_size() <= kPageSize); This should actually be ASSERT(page->area_size() <= kNonCodeObjectAreaSize); https://codereview.chromium.org/11275229/diff/1/src/spaces-inl.h#newcode169 src/spaces-inl.h:169: ASSERT(chunk->size() <= static_cast<size_t>(kPageSize) || I am not sure if we should even have this second assertion anymore. If nobody beside the MemoryAllocator should rely on chunk->size() being a special size, we should not assert it here. So I think we should completely remove the second assert, but could be convinced otherwise. https://codereview.chromium.org/11275229/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
