On 2012/11/14 12:13:13, rossberg wrote:
On 2012/11/14 10:19:26, rossberg wrote:
> LGTM, with nit.

Actually, please add a test case.

Can you point me in the direction of adding a test case that will reliably fail? The reasons why my existing test case fails are mysterious to me (e.g., why does it only happen when using an InternalArray?). Basically, how can I be assured that we've generated code for setting .length and that we're running the stub
the second time through?

https://codereview.chromium.org/11275292/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to