https://codereview.chromium.org/11410080/diff/6002/src/incremental-marking-inl.h File src/incremental-marking-inl.h (right):
https://codereview.chromium.org/11410080/diff/6002/src/incremental-marking-inl.h#newcode44 src/incremental-marking-inl.h:44: // TODO(hpayer): make decision based on if object has a progress bar On 2012/11/15 18:04:26, Michael Starzinger wrote:
As discussed offline, can we rebase that to the brand new progress bar
and check
for the HAS_PROGRESS_BAR page flag here?
Done. I will add the optimization in the next CL. https://codereview.chromium.org/11410080/diff/6002/src/incremental-marking-inl.h#newcode49 src/incremental-marking-inl.h:49: } else if (Marking::IsBlack(obj_bit)) { On 2012/11/15 18:04:26, Michael Starzinger wrote:
Can we rewrite the condition so that it does the Marking::IsBlack only
once,
unfortunately GCC isn't smart enough to optimize it away.
Done. https://codereview.chromium.org/11410080/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
