Drive-by-comments.

https://chromiumcodereview.appspot.com/11280054/diff/1/src/objects-inl.h
File src/objects-inl.h (right):

https://chromiumcodereview.appspot.com/11280054/diff/1/src/objects-inl.h#newcode2345
src/objects-inl.h:2345: FixedDoubleArray* FixedDoubleArray::cast(Object*
object) {
As discussed offline, I don't like this new casting function. It is
lying about the return type. Can we instead have a second
FixedDoubleArray::castButAllowEmptyFixedArray() that does this? That one
would still be lying about the return type, but at least the function
name is scary enough to let people know what's going on.

BTW, I am flexible about the name as long as it sounds complicated and
scary. :)

https://chromiumcodereview.appspot.com/11280054/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to