LGTM with a nit.
https://chromiumcodereview.appspot.com/11299004/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):
https://chromiumcodereview.appspot.com/11299004/diff/1/src/hydrogen.cc#newcode6669
src/hydrogen.cc:6669: fast_mode = false;
On 2012/11/19 12:26:15, Massi wrote:
On 2012/11/16 12:57:10, Jakob wrote:
> Why do you always set this to false?
Because in this case I will emit an instance check instead of a map
check, so I
really cannot know if the arrays that will be handled will be in fast
more or
not.
Makes sense. Please add a comment to that effect. Suggestion:
// We'll emit an instance type check when map_mode == false,
which
// doesn't check elements kinds, so we have to pessimistically
assume
// that some arrays will contain slow elements.
https://chromiumcodereview.appspot.com/11299004/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
