https://codereview.chromium.org/11093074/diff/1/src/full-codegen.cc File src/full-codegen.cc (right):
https://codereview.chromium.org/11093074/diff/1/src/full-codegen.cc#newcode764 src/full-codegen.cc:764: // context in the host context. Can we abstract this index magic into a separate class instead of re-using a plain FixedArray? The comments should go there, if they are necessary then at all. Even publicly inheriting from FixedArray (which we do a lot) might be a win. https://codereview.chromium.org/11093074/diff/1/src/full-codegen.cc#newcode822 src/full-codegen.cc:822: description->set(1, *scope->GetScopeInfo()); See my comment above about FixedArray. The description seems to be a sum type, at least this layout is different from the one above. Anyway, this is hard to follow in its current form. https://codereview.chromium.org/11093074/diff/1/src/runtime.cc File src/runtime.cc (right): https://codereview.chromium.org/11093074/diff/1/src/runtime.cc#newcode1361 src/runtime.cc:1361: ASSERT(is_var + is_const + is_function == 1); Cunning check for mutual exclusion... o_O Anyway, I don't think we need this here, but I leave it up to you. https://codereview.chromium.org/11093074/diff/1/src/runtime.cc#newcode8517 src/runtime.cc:8517: static_cast<PropertyAttributes>(READ_ONLY | DONT_DELETE | DONT_ENUM); On 2012/11/20 12:05:05, Michael Starzinger wrote:
It might make sense to move these constants into the
PropertyAttributes class
itself, so that others can use them as well.
... and it would make even more sense to clean up the confusion between elements of a set and a set itself, but that is a different story. :-) https://codereview.chromium.org/11093074/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
