Reviewers: Michael Starzinger,
Message:
Make --prof_lazy log the addresses of shared libraries.
Without those addresses, the output of the tick processor is not very
useful for
node.js applications.
Address logging was disabled for --prof-lazy in r3154 for reasons that no
longer
apply: the profiler is started on demand and hence looking up the addresses
is
deferred until it's actually necessary.
Description:
profiler: log solib addresses unconditionally
Make --prof_lazy log the addresses of shared libraries. Without those
addresses,
the output of the tick processor is not very useful for node.js
applications.
Address logging was disabled for --prof-lazy in r3154 for reasons that no
longer
apply: the profiler is started on demand and hence looking up the addresses
is
deferred until it's actually necessary.
Please review this at https://codereview.chromium.org/11309007/
Affected files:
M src/log.cc
Index: src/log.cc
diff --git a/src/log.cc b/src/log.cc
index
b049ffe4eb7557ec879050b975896a887a1a6d4c..662916ef55491e4f8e0394c829bf113a1dedbe1d
100644
--- a/src/log.cc
+++ b/src/log.cc
@@ -283,11 +283,7 @@ void Profiler::Engage() {
if (engaged_) return;
engaged_ = true;
- // TODO(mnaganov): This is actually "Chromium" mode. Flags need to be
revised.
- // http://code.google.com/p/v8/issues/detail?id=487
- if (!FLAG_prof_lazy) {
- OS::LogSharedLibraryAddresses();
- }
+ OS::LogSharedLibraryAddresses();
// Start thread processing the profiler buffer.
running_ = true;
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
