Reviewers: Michael Starzinger,
Description:
Enable deprecations.
In addition, use a more common style in the preprocessor condition, making
e.g. '-DV8_ENABLE_DEPRECATIONS=0' do the expected thing. Removed a useles
Please review this at https://codereview.chromium.org/11413113/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M include/v8.h
M src/api.cc
Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index
28bea2e3e4435b39a4b50a140513560b80b3fd85..d7243c688f2e7e756f8ed5a6e8d89305e50f6551
100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -76,12 +76,10 @@
#endif // _WIN32
-// TODO(svenpanne) Remove this when the Chrome's v8 bindings have been
adapted.
-#define V8_DISABLE_DEPRECATIONS 1
-#if defined(__GNUC__) && !defined(V8_DISABLE_DEPRECATIONS)
+#if defined(__GNUC__) && !V8_DISABLE_DEPRECATIONS
#define V8_DEPRECATED(func) func __attribute__ ((deprecated))
-#elif defined(_MSC_VER) && !defined(V8_DISABLE_DEPRECATIONS)
+#elif defined(_MSC_VER) && !V8_DISABLE_DEPRECATIONS
#define V8_DEPRECATED(func) __declspec(deprecated) func
#else
#define V8_DEPRECATED(func) func
Index: src/api.cc
diff --git a/src/api.cc b/src/api.cc
index
3c4496055f772f83d67ebd925a21f671e0e00498..eb29c16db70f95a1c44849404a5d61bd58296dd6
100644
--- a/src/api.cc
+++ b/src/api.cc
@@ -25,9 +25,6 @@
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-// Deprecated API entries use other deprecated entries, too.
-#define V8_DISABLE_DEPRECATIONS 1
-
#include "api.h"
#include <math.h> // For isnan.
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
