https://codereview.chromium.org/11299154/diff/2001/src/extensions/gc-extension.cc
File src/extensions/gc-extension.cc (right):

https://codereview.chromium.org/11299154/diff/2001/src/extensions/gc-extension.cc#newcode47
src/extensions/gc-extension.cc:47:
SetFlags(Heap::kAbortIncrementalMarkingMask);
You should just pass the GC flag directly in the call. Passing it like
this is basically a NOP, because it will be overridden by the subsequent
GC call.

https://codereview.chromium.org/11299154/diff/2001/src/heap.cc
File src/heap.cc (left):

https://codereview.chromium.org/11299154/diff/2001/src/heap.cc#oldcode5325
src/heap.cc:5325: if (hint >= mark_sweep_time && !FLAG_expose_gc &&
Ulan, could you look at the IdelNotification changes?

https://codereview.chromium.org/11299154/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to