lgtm if you address the comments.
https://codereview.chromium.org/11316105/diff/1/src/arm/lithium-arm.cc File src/arm/lithium-arm.cc (right): https://codereview.chromium.org/11316105/diff/1/src/arm/lithium-arm.cc#newcode1236 src/arm/lithium-arm.cc:1236: return constant_val->CopyToRepresentation(Representation::Integer32(), Is it possible to not duplicate the very similar constant code to the SUDIV case? e.g. turning the "if (LChunkBuilder::HasMagicNumberForDivisor(int32_val)) {" into "if (LChunkBuilder::HasMagicNumberForDivisor(int32_val) || CpuFeatures::IsSupported(SUDIV)) {"? https://codereview.chromium.org/11316105/diff/1/src/arm/lithium-codegen-arm.cc File src/arm/lithium-codegen-arm.cc (right): https://codereview.chromium.org/11316105/diff/1/src/arm/lithium-codegen-arm.cc#newcode1402 src/arm/lithium-codegen-arm.cc:1402: // We operated a truncating division. Correct the result if necessary. nit: s/operated/performed https://codereview.chromium.org/11316105/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
