Be careful with the performance of this. You've made parsing large array
literals much slower, please verify that you don't see a negative impact on
the
Kraken benchmarks that have very large initial data sets declared in an
array
literal.
https://codereview.chromium.org/11361281/diff/4001/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/11361281/diff/4001/src/parser.cc#newcode3726
src/parser.cc:3726: bool is_holey = false;
Can't you automatically track holiness through SetOwnElement? If you
skip an element, the array's elements kind should become holey.
https://codereview.chromium.org/11361281/diff/4001/src/parser.cc#newcode3739
src/parser.cc:3739: } else if (!boilerplate_value->IsTheHole()) {
You already know !boilerplate_value->IsTheHole() is true, since you
checked above.
https://codereview.chromium.org/11361281/diff/4001/src/parser.cc#newcode3758
src/parser.cc:3758: kind = is_holey ? GetHoleyElementsKind(kind) :
GetPackedElementsKind(kind);
Shouldn't be necessary, see above.
https://codereview.chromium.org/11361281/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
