Revision: 13065
Author:   [email protected]
Date:     Tue Nov 27 04:52:51 2012
Log:      Make unit tests that fill new-space work under stress.

This makes sure that unit tests that try to fill up the new-space work
on the GC stress buildbots as well.

[email protected]
TEST=cctest/test-heap --gc-interval=500 --stress-compaction

Review URL: https://codereview.chromium.org/11416200
http://code.google.com/p/v8/source/detail?r=13065

Modified:
 /branches/bleeding_edge/test/cctest/test-heap.cc

=======================================
--- /branches/bleeding_edge/test/cctest/test-heap.cc Tue Nov 20 02:47:31 2012 +++ /branches/bleeding_edge/test/cctest/test-heap.cc Tue Nov 27 04:52:51 2012
@@ -1944,7 +1944,7 @@
   if (!i::V8::UseCrankshaft() || i::FLAG_always_opt) return;
   v8::HandleScope scope;

-  FillUpNewSpace(HEAP->new_space());
+  SimulateFullSpace(HEAP->new_space());
   AlwaysAllocateScope always_allocate;
   v8::Local<v8::Value> res = CompileRun(
       "function c(x) {"
@@ -2153,14 +2153,9 @@

     // Generate a sliced string that is based on the above parent and
     // lives in old-space.
-    FillUpNewSpace(HEAP->new_space());
+    SimulateFullSpace(HEAP->new_space());
     AlwaysAllocateScope always_allocate;
-    Handle<String> t;
-    // TODO(mstarzinger): Unfortunately FillUpNewSpace() still leaves
-    // some slack, so we need to allocate a few sliced strings.
-    for (int i = 0; i < 16; i++) {
-      t = FACTORY->NewProperSubString(s, 5, 35);
-    }
+    Handle<String> t = FACTORY->NewProperSubString(s, 5, 35);
     CHECK(t->IsSlicedString());
     CHECK(!HEAP->InNewSpace(*t));
     *slice.location() = *t.location();

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to