After discussing it offline I see the point of this CL, sorry for the
initial
confusion. A few high-level comments.
https://codereview.chromium.org/11348174/diff/2001/src/spaces.cc
File src/spaces.cc (right):
https://codereview.chromium.org/11348174/diff/2001/src/spaces.cc#newcode2196
src/spaces.cc:2196: static intptr_t
CountFreeListItemsInList(FreeListCategorie* categorie,
I think the code would be easier to read if the static helpers would
still be based on the FreeListNode and you would just pass in
foo_list_.top into the static helper. Same applies to the functions
below.
https://codereview.chromium.org/11348174/diff/2001/src/spaces.h
File src/spaces.h (right):
https://codereview.chromium.org/11348174/diff/2001/src/spaces.h#newcode1378
src/spaces.h:1378: struct FreeListCategorie {
This should be a proper class with the helper functions as member
methods. Also naming it "FreeListCategory" is better I guess. Also some
comments above the class describing it's purpose would be nice.
https://codereview.chromium.org/11348174/diff/2001/src/spaces.h#newcode1414
src/spaces.h:1414: void Reset(struct FreeListCategorie *categorie);
Move all of these helper functions into FreeListCategory.
https://codereview.chromium.org/11348174/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
