Reviewers: Yang,
Description:
Disable stress for some unit test.
Some unit tests specifically test scavenges and forcing them to do
global GCs instead makes no sense. The GC stress builder triggers this.
[email protected]
TEST=cctest/test-api --stress-compaction
Please review this at https://codereview.chromium.org/11421098/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M test/cctest/test-api.cc
M test/cctest/test-mark-compact.cc
Index: test/cctest/test-api.cc
diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc
index
a51d3012a5a8f3c1929d122f9288bb95d2236e2c..957f131342f0e020443447e5a52298db2e2c5faa
100644
--- a/test/cctest/test-api.cc
+++ b/test/cctest/test-api.cc
@@ -626,6 +626,8 @@ THREADED_TEST(UsingExternalAsciiString) {
THREADED_TEST(ScavengeExternalString) {
+ i::FLAG_stress_compaction = false;
+ i::FLAG_gc_global = false;
int dispose_count = 0;
bool in_new_space = false;
{
@@ -646,6 +648,8 @@ THREADED_TEST(ScavengeExternalString) {
THREADED_TEST(ScavengeExternalAsciiString) {
+ i::FLAG_stress_compaction = false;
+ i::FLAG_gc_global = false;
int dispose_count = 0;
bool in_new_space = false;
{
@@ -2546,6 +2550,8 @@ THREADED_TEST(ApiObjectGroupsCycle) {
// TODO(mstarzinger): This should be a THREADED_TEST but causes failures
// on the buildbots, so was made non-threaded for the time being.
TEST(ApiObjectGroupsCycleForScavenger) {
+ i::FLAG_stress_compaction = false;
+ i::FLAG_gc_global = false;
HandleScope scope;
LocalContext env;
Index: test/cctest/test-mark-compact.cc
diff --git a/test/cctest/test-mark-compact.cc
b/test/cctest/test-mark-compact.cc
index
c0ab763a28544614befd0ebc490bd8e174f685d5..69abd8d6800e1543e788508c0eab109a9eeb0297
100644
--- a/test/cctest/test-mark-compact.cc
+++ b/test/cctest/test-mark-compact.cc
@@ -311,6 +311,7 @@ static void
WeakPointerCallback(v8::Persistent<v8::Value> handle, void* id) {
}
TEST(ObjectGroups) {
+ FLAG_incremental_marking = false;
InitializeVM();
GlobalHandles* global_handles = Isolate::Current()->global_handles();
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
