Reviewers: danno, Michael Starzinger, loislo, alph,
Description:
Introduce callback for resolving global object name while taking heap
snapshot
Heap profiler currently gets "document" of global objects while taking
snapshot
(to later retrieve its "URL"). This is unsafe as there may be no current v8
context when the property is requested while corresponding property
accessor may
make some assumptions about the context stack during its invokation. Several
crashes were reported due to this problem:
https://bugs.webkit.org/show_bug.cgi?id=103076
https://crbug.com/162121
https://crbug.com/132727
This patch adds a callback for resolving global object names and avoid the
crashes.
Please review this at https://codereview.chromium.org/11415203/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M include/v8-profiler.h
M src/api.cc
M src/heap-profiler.h
M src/heap-profiler.cc
M src/profile-generator.h
M src/profile-generator.cc
M test/cctest/test-heap-profiler.cc
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
