Still LGTM.
https://codereview.chromium.org/10701054/diff/67140/src/hydrogen.h File src/hydrogen.h (right): https://codereview.chromium.org/10701054/diff/67140/src/hydrogen.h#newcode1304 src/hydrogen.h:1304: DEFINE_AST_VISITOR_SUBCLASS_MEMBERS(); On 2012/11/30 16:23:24, danno wrote:
On 2012/11/28 16:28:22, Jakob wrote: > These used to be public; did you move them to the private section intentionally?
Done.
Actually, since the macro's expansions contains appropriate public/private section headers, it doesn't matter at all. Never mind. https://codereview.chromium.org/10701054/diff/76003/src/ast.h File src/ast.h (right): https://codereview.chromium.org/10701054/diff/76003/src/ast.h#newcode2515 src/ast.h:2515: public: \ I meant: 1 space indentation for "public:" https://codereview.chromium.org/10701054/diff/76003/src/ast.h#newcode2531 src/ast.h:2531: private: \ I meant: 1 space indentation for "private:" https://codereview.chromium.org/10701054/diff/76003/src/ia32/assembler-ia32.h File src/ia32/assembler-ia32.h (right): https://codereview.chromium.org/10701054/diff/76003/src/ia32/assembler-ia32.h#newcode183 src/ia32/assembler-ia32.h:183: XMMRegister r = XMMRegister(code); It seems you forgot to change this. I suggested to simply "return XMMRegister(code);". https://codereview.chromium.org/10701054/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
