Revision: 13125
Author: [email protected]
Date: Tue Dec 4 00:58:59 2012
Log: Remove extraneous forced rejuvenations in code aging
[email protected]
Review URL: https://codereview.chromium.org/11421219
http://code.google.com/p/v8/source/detail?r=13125
Modified:
/branches/bleeding_edge/src/compiler.cc
/branches/bleeding_edge/src/flag-definitions.h
/branches/bleeding_edge/src/objects.cc
/branches/bleeding_edge/src/objects.h
=======================================
--- /branches/bleeding_edge/src/compiler.cc Mon Dec 3 09:16:51 2012
+++ /branches/bleeding_edge/src/compiler.cc Tue Dec 4 00:58:59 2012
@@ -618,7 +618,6 @@
if (result->ic_age() != HEAP->global_ic_age()) {
result->ResetForNewContext(HEAP->global_ic_age());
}
- result->code()->MakeYoung();
}
if (result.is_null()) isolate->ReportPendingMessages();
@@ -680,7 +679,6 @@
if (result->ic_age() != HEAP->global_ic_age()) {
result->ResetForNewContext(HEAP->global_ic_age());
}
- result->code()->MakeYoung();
}
return result;
=======================================
--- /branches/bleeding_edge/src/flag-definitions.h Tue Dec 4 00:16:24 2012
+++ /branches/bleeding_edge/src/flag-definitions.h Tue Dec 4 00:58:59 2012
@@ -400,7 +400,7 @@
"flush code that we expect not to use again (during full gc)")
DEFINE_bool(flush_code_incrementally, true,
"flush code that we expect not to use again (incrementally)")
-DEFINE_bool(age_code, false,
+DEFINE_bool(age_code, true,
"track un-executed functions to age code and flush only "
"old code")
DEFINE_bool(incremental_marking, true, "use incremental marking")
=======================================
--- /branches/bleeding_edge/src/objects.cc Mon Dec 3 09:16:51 2012
+++ /branches/bleeding_edge/src/objects.cc Tue Dec 4 00:58:59 2012
@@ -7972,7 +7972,6 @@
ASSERT(code != NULL);
ASSERT(function->context()->native_context() == code_map->get(index -
1));
function->ReplaceCode(code);
- code->MakeYoung();
}
@@ -8839,14 +8838,6 @@
void Code::MakeCodeAgeSequenceYoung(byte* sequence) {
PatchPlatformCodeAge(sequence, kNoAge, NO_MARKING_PARITY);
}
-
-
-void Code::MakeYoung() {
- byte* sequence = FindCodeAgeSequence();
- if (sequence != NULL) {
- PatchPlatformCodeAge(sequence, kNoAge, NO_MARKING_PARITY);
- }
-}
void Code::MakeOlder(MarkingParity current_parity) {
=======================================
--- /branches/bleeding_edge/src/objects.h Mon Dec 3 09:16:51 2012
+++ /branches/bleeding_edge/src/objects.h Tue Dec 4 00:58:59 2012
@@ -4573,7 +4573,6 @@
// Code aging
static void MakeCodeAgeSequenceYoung(byte* sequence);
- void MakeYoung();
void MakeOlder(MarkingParity);
static bool IsYoungSequence(byte* sequence);
bool IsOld();
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
