Revision: 13126
Author: [email protected]
Date: Tue Dec 4 01:51:52 2012
Log: Remove bogus test and add check for OOM in TryCall.
[email protected]
BUG=
Review URL: https://chromiumcodereview.appspot.com/11412318
http://code.google.com/p/v8/source/detail?r=13126
Modified:
/branches/bleeding_edge/src/execution.cc
/branches/bleeding_edge/test/cctest/test-debug.cc
=======================================
--- /branches/bleeding_edge/src/execution.cc Fri Nov 16 02:57:50 2012
+++ /branches/bleeding_edge/src/execution.cc Tue Dec 4 01:51:52 2012
@@ -211,6 +211,9 @@
Isolate* isolate = Isolate::Current();
ASSERT(isolate->has_pending_exception());
ASSERT(isolate->external_caught_exception());
+ if (isolate->is_out_of_memory() && !isolate->ignore_out_of_memory()) {
+ V8::FatalProcessOutOfMemory("OOM during Execution::TryCall");
+ }
if (isolate->pending_exception() ==
isolate->heap()->termination_exception()) {
result = isolate->factory()->termination_exception();
=======================================
--- /branches/bleeding_edge/test/cctest/test-debug.cc Mon Dec 3 09:57:17
2012
+++ /branches/bleeding_edge/test/cctest/test-debug.cc Tue Dec 4 01:51:52
2012
@@ -7532,18 +7532,4 @@
}
-TEST(DebugContextOOM) {
- v8::HandleScope scope;
- LocalContext context;
- v8::V8::IgnoreOutOfMemoryException();
-
- v8::Local<v8::Value> result = CompileRun("a = '1'; while (true) a +=
a;");
-
- // Check for out of memory state.
- CHECK(result.IsEmpty());
- CHECK(context->HasOutOfMemoryException());
-
- v8::Debug::GetDebugContext();
-}
-
#endif // ENABLE_DEBUGGER_SUPPORT
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev