On 2012/12/04 09:51:05, Michael Starzinger wrote:
This change is not GC safe.
https://codereview.chromium.org/11421100/diff/3002/src/liveedit.cc
File src/liveedit.cc (right):
https://codereview.chromium.org/11421100/diff/3002/src/liveedit.cc#newcode955
src/liveedit.cc:955: factory->LookupAsciiSymbol("startPosition"),
This pattern is not GC safe. Other handles might have been dereferenced
before
the call to LookupAsciiSymbol, which in turn can cause a GC. The factory
call
needs to be done separately before a sequence point.
https://codereview.chromium.org/11421100/diff/3002/src/liveedit.cc#newcode959
src/liveedit.cc:959: factory->LookupAsciiSymbol("endPosition"),
Likewise.
https://codereview.chromium.org/11421100/diff/3002/src/liveedit.cc#newcode963
src/liveedit.cc:963: factory->LookupAsciiSymbol("scriptObject"),
Likewise.
I'll fix this.
https://codereview.chromium.org/11421100/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
