LGTM (with micro-nits). I also verified that it doesn't tank performance on Octane's code load benchmark.
https://codereview.chromium.org/11438042/diff/8001/src/parser.cc File src/parser.cc (right): https://codereview.chromium.org/11438042/diff/8001/src/parser.cc#newcode638 src/parser.cc:638: mode = PARSE_EAGERLY; Curly braces around body. https://codereview.chromium.org/11438042/diff/8001/test/mjsunit/regress/regress-2315.js File test/mjsunit/regress/regress-2315.js (right): https://codereview.chromium.org/11438042/diff/8001/test/mjsunit/regress/regress-2315.js#newcode34 test/mjsunit/regress/regress-2315.js:34: for (var i = 0; i < 10; ++i) foo(); Is there a particular reason we need two separate loops here? https://codereview.chromium.org/11438042/diff/8001/test/mjsunit/regress/regress-492.js File test/mjsunit/regress/regress-492.js (right): https://codereview.chromium.org/11438042/diff/8001/test/mjsunit/regress/regress-492.js#newcode90 test/mjsunit/regress/regress-492.js:90: for (var i = 0; i < 10; ++i) foo(); Is there a particular reason we need two loops here? https://codereview.chromium.org/11438042/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
